Skip to content

esptool: 2.7 -> 3.0, fix #82965#107389

Merged
lovesegfault merged 1 commit intoNixOS:masterfrom
LumiGuide:esptool
Dec 22, 2020
Merged

esptool: 2.7 -> 3.0, fix #82965#107389
lovesegfault merged 1 commit intoNixOS:masterfrom
LumiGuide:esptool

Conversation

@yorickvP
Copy link
Copy Markdown
Contributor

@yorickvP yorickvP commented Dec 22, 2020

Motivation for this change

Esptool version 3.0 was released on nov 5. I also fixed #82965.

cc: @wucke13 @dezgeg @dotlambda

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yorickvP yorickvP requested review from dezgeg and dotlambda December 22, 2020 10:49
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 22, 2020
@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Dec 22, 2020

Result of nixpkgs-review pr 107389 run on x86_64-darwin 1

@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Dec 22, 2020

Result of nixpkgs-review pr 107389 run on x86_64-linux 1

2 packages built:
  • esphome
  • esptool

1 similar comment
@lovesegfault
Copy link
Copy Markdown
Member

lovesegfault commented Dec 22, 2020

Result of nixpkgs-review pr 107389 run on x86_64-linux 1

2 packages built:
  • esphome
  • esptool

@lovesegfault
Copy link
Copy Markdown
Member

lovesegfault commented Dec 22, 2020

Tested and working

@lovesegfault lovesegfault merged commit aebe77d into NixOS:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

esptool's espefuse.py doesn't work

3 participants

@yorickvP @SuperSandro2000 @lovesegfault