Skip to content

rust-analyzer: 2020-11-09 -> 2020-12-21#107347

Closed
bkchr wants to merge 1 commit intoNixOS:masterfrom
bkchr:bkchr-update-rust-analyzer-12-21
Closed

rust-analyzer: 2020-11-09 -> 2020-12-21#107347
bkchr wants to merge 1 commit intoNixOS:masterfrom
bkchr:bkchr-update-rust-analyzer-12-21

Conversation

@bkchr
Copy link
Copy Markdown
Contributor

@bkchr bkchr commented Dec 21, 2020 •
edited
Loading

Motivation for this change

New version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC @oxalica @jonringer

@fabianhjr fabianhjr mentioned this pull request Dec 21, 2020
Merged
@oxalica
Copy link
Copy Markdown
Contributor

oxalica commented Dec 22, 2020

vscode-extensions.matklad.rust-analyzer failed to build for me.

node_rust-analyzer> > tsc && rollup -c
node_rust-analyzer> sh: tsc: command not found

Do you forget to update package.json and node-packages simultaneously?
You can reset to master and run pkgs/development/tools/rust/rust-analyzer/update.sh, which will update all of them.

@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Dec 22, 2020

@ofborg eval

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 22, 2020
@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Dec 22, 2020

Result of nixpkgs-review pr 107347 run on x86_64-linux 1

1 package failed to build:
  • vscode-extensions.matklad.rust-analyzer
2 packages built:
  • rust-analyzer
  • rust-analyzer-unwrapped

@bkchr
Copy link
Copy Markdown
Contributor Author

bkchr commented Dec 22, 2020

vscode-extensions.matklad.rust-analyzer failed to build for me.

node_rust-analyzer> > tsc && rollup -c
node_rust-analyzer> sh: tsc: command not found

Do you forget to update package.json and node-packages simultaneously?
You can reset to master and run pkgs/development/tools/rust/rust-analyzer/update.sh, which will update all of them.

Ahh did not tried this. I just have seen that the vscode version is too old.

@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Dec 23, 2020

Ahh did not tried this. I just have seen that the vscode version is too old.

I would be fine if this would be bumped in this PR.

@bkchr bkchr closed this Jan 5, 2021
@bkchr bkchr deleted the bkchr-update-rust-analyzer-12-21 branch January 5, 2021 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bkchr @oxalica @SuperSandro2000