Skip to content

scalameta.metals: 1.9.7->1.9.10#107340

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
scalavision:update-scalameta.metals-to-1.9.10
Jan 20, 2021
Merged

scalameta.metals: 1.9.7->1.9.10#107340
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
scalavision:update-scalameta.metals-to-1.9.10

Conversation

@scalavision
Copy link
Copy Markdown
Contributor

@scalavision scalavision commented Dec 21, 2020 •
edited
Loading

Motivation for this change

aligning scalameta.metals with last version of Scala 3.0.0-M3. This version of scala has full support for Scala.js and other improvements, so it would be very nice to have this in.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [x ] Ensured that relevant documentation is up to date
  • [x ] Fits CONTRIBUTING.md.

@scalavision scalavision force-pushed the update-scalameta.metals-to-1.9.10 branch from 51c30c6 to 70ea8a1 Compare December 21, 2020 19:30
@scalavision scalavision changed the title scalameta.metals: 1.9.9->1.9.10 scalameta.metals: 1.9.7->1.9.10 Dec 21, 2020
prusnak
prusnak approved these changes Dec 21, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested, change looks OK

@fabianhjr fabianhjr mentioned this pull request Dec 21, 2020
Merged
@scalavision
Copy link
Copy Markdown
Contributor Author

scalavision commented Dec 22, 2020

Yeah.. I have problems building things locally with some error on the python plugin. I haven't found a nice way to only build this plugin, without all the other dependencies ..

@scalavision
Copy link
Copy Markdown
Contributor Author

scalavision commented Dec 22, 2020 •
edited
Loading

seems this did the trick:

nix-build -E 'with import <nixpkgs> {}; callPackage ./default.nix { }' -A scalameta.metals

then symlinking in manually. Tested the plugin now, it works as expected.

@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Jan 18, 2021

@scalavision please fix the eval error.

@scalavision
Copy link
Copy Markdown
Contributor Author

scalavision commented Jan 18, 2021

what do you mean @SuperSandro2000 , is it the problem with ofborg? How can I fix it?

@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Jan 18, 2021

is it the problem with ofborg? How can I fix it?

yes. It is required to be green before the PR can be merged.

@ofborg eval

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 18, 2021
@scalavision
Copy link
Copy Markdown
Contributor Author

scalavision commented Jan 20, 2021

oki, hm... didn't know I had privilege to do that :-) Thanks for helping out!

@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Jan 20, 2021

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107340 run on x86_64-linux 1

1 package built:
  • vscode-extensions.scalameta.metals

@SuperSandro2000 SuperSandro2000 merged commit 96df69a into NixOS:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prusnak prusnak prusnak approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scalavision @SuperSandro2000 @prusnak