Skip to content

thunderbird: Add gpg/gpgme dependencies to fix smartcard usage#107122

Merged
nh2 merged 3 commits intoNixOS:masterfrom
nh2:thunderbird-gpgme
Dec 23, 2020
Merged

thunderbird: Add gpg/gpgme dependencies to fix smartcard usage#107122
nh2 merged 3 commits intoNixOS:masterfrom
nh2:thunderbird-gpgme

Conversation

@nh2
Copy link
Copy Markdown
Contributor

@nh2 nh2 commented Dec 17, 2020 •
edited
Loading

Motivation for this change

Fixes #98765.

This enables to configure Thunderbird to use gnupg directly, which is the
official upstream recommendation when using GPG with smartcards, which are not
yet supported by Thunderbird's native GPG support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
      • master @ fe8f558
      • I've tested on NixOS 20.09 but not yet on master
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • 576 MB -> 599 MB
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2
thunderbird: Add gpg/gpgme dependencies. Fixes NixOS#98765.
2767936 
This enables to configure Thunderbird to use gnupg directly, which is the
official upstream recommendation when using GPG with smartcards, which are not
yet supported by Thunderbird's native GPG support.
@nh2 nh2 requested review from lovesegfault and vcunat December 17, 2020 23:39
@nh2 nh2 mentioned this pull request Dec 17, 2020
Closed
@nh2
Copy link
Copy Markdown
Contributor Author

nh2 commented Dec 18, 2020

Tested on master as well now, works well for me.

@taku0
Copy link
Copy Markdown
Contributor

taku0 commented Dec 19, 2020

Could you also add them to thunderbird-bin?

@ofborg ofborg bot requested review from edolstra and nbp December 19, 2020 23:05
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 19, 2020
@nh2
Copy link
Copy Markdown
Contributor Author

nh2 commented Dec 22, 2020

Could you also add them to thunderbird-bin?

@taku0 Done, and it works for me as well.

I've also added a small refactoring commit sort the import lists, which should not change the eval.

lovesegfault
lovesegfault approved these changes Dec 22, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM

taku0
taku0 approved these changes Dec 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nh2 nh2 merged commit db9a283 into NixOS:master Dec 23, 2020
@nh2 nh2 mentioned this pull request Jan 1, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taku0 taku0 taku0 approved these changes

@lovesegfault lovesegfault lovesegfault approved these changes

@vcunat vcunat Awaiting requested review from vcunat

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

thunderbird@78: enable smartcard gpg support

3 participants

@nh2 @taku0 @lovesegfault