Skip to content

firefox: Prefix $PATH with xdg_utils#105894

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
ryneeverett:firefox-xdg
Dec 11, 2020
Merged

firefox: Prefix $PATH with xdg_utils#105894
mweinelt merged 1 commit intoNixOS:masterfrom
ryneeverett:firefox-xdg

Conversation

@ryneeverett
Copy link
Copy Markdown
Contributor

@ryneeverett ryneeverett commented Dec 4, 2020

Motivation for this change

Resolve #92751.

Comparable to #96922.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 4, 2020
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Dec 4, 2020 •
edited
Loading

Firefox is currently your default browser

❤️

Edit: testing this messed up my browser profile … wow. 😢

@ryneeverett
Copy link
Copy Markdown
Contributor Author

ryneeverett commented Dec 4, 2020

Edit: testing this messed up my browser profile … wow.

Yikes. I'm guessing this is the result of another firefox patch that landed in master yesterday.

@ryneeverett
Copy link
Copy Markdown
Contributor Author

ryneeverett commented Dec 4, 2020

#91724

@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Dec 4, 2020 via email

@mweinelt mweinelt added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 5, 2020
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Dec 5, 2020

Can you please add a motivation to your commit message, so that we don't need to rely on GitHub history to follow the intent of your commit.

@ryneeverett
firefox: Prefix $PATH with xdg_utils
36436ee 
This is required for certain URIs that require launching external
programs (e.g. mailto:, magnet:, or irc:) or setting the default browser
via xdg-settings.

Resolve NixOS#92751.

Comparable to NixOS#96922.
@symphorien
Copy link
Copy Markdown
Member

symphorien commented Dec 11, 2020

@GrahamcOfBorg firefox

@symphorien
Copy link
Copy Markdown
Member

symphorien commented Dec 11, 2020

ah oops
@GrahamcOfBorg build firefox

@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Dec 11, 2020

I've run with this for close to a week. Thanks!

@mweinelt mweinelt merged commit 6a163d2 into NixOS:master Dec 11, 2020
@erictapen
Copy link
Copy Markdown
Member

erictapen commented Jan 13, 2021

Backported this in 1b5f650.

@erictapen erictapen added 8.has: port to stable This PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt mweinelt approved these changes

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setting browsers (Firefox, Chromium) as default have no effect in Sway.

4 participants

@ryneeverett @mweinelt @symphorien @erictapen