Skip to content

treewide: run ./maintainers/scripts/update_redirected_urls.sh#105101

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
SuperSandro2000:update-url-redirects
Nov 27, 2020
Merged

treewide: run ./maintainers/scripts/update_redirected_urls.sh#105101
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
SuperSandro2000:update-url-redirects

Conversation

@SuperSandro2000
Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Motivation for this change

#101464

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Copy Markdown
Contributor

jonringer commented Nov 27, 2020

already got a conflict :(

@SuperSandro2000
Copy link
Copy Markdown
Member Author

SuperSandro2000 commented Nov 27, 2020 •
edited
Loading

already got a conflict :(

That took like 2 minutes. Going to merge it asap when I fixed that.

Edit: I think I know why: I did not fetch the other PR I linked as motivation. Classical derp.

@SuperSandro2000 SuperSandro2000 merged commit 9993ffb into NixOS:master Nov 27, 2020
@SuperSandro2000 SuperSandro2000 deleted the update-url-redirects branch November 27, 2020 00:38
@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 27, 2020
@pbsds pbsds mentioned this pull request Oct 4, 2024
Open
@pbsds pbsds mentioned this pull request Jan 17, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@stigtsp stigtsp Awaiting requested review from stigtsp

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SuperSandro2000 @jonringer