Skip to content

loaOf deprecation warnings or errors #77189

Closed
Closed
loaOf deprecation warnings or errors#77189
Labels
0.kind: bugSomething is broken3.skill: sprintableA larger issue which is split into distinct actionable tasks3.skill: trivialThis is trivial to complete (typically find-and-replace)6.topic: nixosIssues or PRs affecting NixOS modules, or package usability issues specific to NixOS
Milestone
20.09
@worldofpeace

Description

@worldofpeace
worldofpeace
opened on Jan 7, 2020

Describe the bug
The type loaOf was deprecated and its use will spring up evaluation warnings like

trace: warning: In file <unknown-file>
a list is being assigned to the option config.fileSystems.
This will soon be an error as type loaOf is deprecated.
See https://git.io/fj2zm for more information.
Do
  fileSystems =
    { unnamed = {...}; ...}
instead of
  fileSystems =
    [ { name = "unnamed"; ...} ...]

This was done in #63103, but because the scope of the change
it wasn't feasible to get them all in one go and there was a few syntax related errors #77177.

rg "loaOf" returned this for me at the time of writing

nixos/modules/config/users-groups.nix:2
nixos/modules/security/pam.nix:1
nixos/modules/tasks/encrypted-devices.nix:1
nixos/modules/tasks/filesystems.nix:2
nixos/modules/tasks/network-interfaces.nix:1
nixos/modules/programs/tsm-client.nix:2
nixos/modules/programs/ssh.nix:1
nixos/modules/virtualisation/railcar.nix:2
nixos/modules/virtualisation/containers.nix:1
nixos/modules/services/backup/znapzend.nix:2
nixos/modules/system/etc/etc.nix:1
nixos/modules/services/desktops/geoclue2.nix:1
nixos/modules/system/boot/stage-1.nix:1
nixos/modules/system/boot/luksroot.nix:1
nixos/modules/services/networking/bitcoind.nix:1
nixos/modules/services/security/tor.nix:1
nixos/modules/services/networking/i2pd.nix:2
nixos/modules/services/x11/picom.nix:3
nixos/modules/services/networking/prosody.nix:1
nixos/modules/services/networking/nylon.nix:1
nixos/doc/manual/development/option-types.xml:1
nixos/modules/installer/tools/nixos-option/nixos-option.cc:1
nixos/modules/services/hardware/sane_extra_backends/brscan4.nix:1
nixos/modules/services/networking/hylafax/options.nix:2
nixos/modules/services/networking/ssh/sshd.nix:1

and it appears some modules were probably added while the PR was opened used the old format.

What to do if encountered
Duplicate such changes like in:

Here's the PR that added the release note, with details about the change #77109.

Metadata

Metadata

Assignees

No one assigned

    Labels

    0.kind: bugSomething is broken3.skill: sprintableA larger issue which is split into distinct actionable tasks3.skill: trivialThis is trivial to complete (typically find-and-replace)6.topic: nixosIssues or PRs affecting NixOS modules, or package usability issues specific to NixOS

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions