Skip to content

Merge profiles/graphical.nix & installer/cd-dvd/installation-cd-graphical-base.nix #47256

@matthewbauer

Description

@matthewbauer

Issue description

These two files are really similar and can hopefully be refactored to reuse the same code. installation-cd-graphical-base.nix was added in #46510 by @worldofpeace. hopefully i understand its use case and we can make it more generic to apply in the virtualbox appliances.

See discussion in #47204

So I think there is some confusion here because profiles/graphical.nix & installer/cd-dvd/installation-cd-graphical-base.nix do almost the exact same thing. The main difference is one is going into the .iso and the other into the .ova. It seems like we should refactor to avoid duplication here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    0.kind: enhancementAdd something new or improve an existing system.6.topic: nixosIssues or PRs affecting NixOS modules, or package usability issues specific to NixOS6.topic: release processIssues or PRs which are parts of the NixOS release process
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions