-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Get rid of md5 support for fixed-output derivations #4491
Copy link
Copy link
Closed
Labels
0.kind: enhancementAdd something new or improve an existing system.Add something new or improve an existing system.1.severity: blockerThis is preventing another PR or issue from being completedThis is preventing another PR or issue from being completed1.severity: securityIssues which raise a security issue, or PRs that fix oneIssues which raise a security issue, or PRs that fix one3.skill: sprintableA larger issue which is split into distinct actionable tasksA larger issue which is split into distinct actionable tasks6.topic: pythonPython is a high-level, general-purpose programming language.Python is a high-level, general-purpose programming language.
Milestone
Metadata
Metadata
Assignees
Labels
0.kind: enhancementAdd something new or improve an existing system.Add something new or improve an existing system.1.severity: blockerThis is preventing another PR or issue from being completedThis is preventing another PR or issue from being completed1.severity: securityIssues which raise a security issue, or PRs that fix oneIssues which raise a security issue, or PRs that fix one3.skill: sprintableA larger issue which is split into distinct actionable tasksA larger issue which is split into distinct actionable tasks6.topic: pythonPython is a high-level, general-purpose programming language.Python is a high-level, general-purpose programming language.
Fields
Give feedbackNo fields configured for issues without a type.
We're in 2014 and even universities have a course where students forge md5 hashes of files.
Biggest usage of md5 hashes in nixpkgs is python, followed by libreoffice (scripted install).
Observations:
nix-prefetch- should print out multiple hashes together with fetch functions supporting and verifying all of specified hashes
Q/A:
it is considered best practice to use it when that's what upstream provides
That's a very bad security practice. It trades user security for few seconds of maintainer time.
TODO
pkgs/games/steam/runtime-generated.nixuses md5 during generation