Skip to content

First-class GitHub team support for review requests #447514

@infinisil

Description

@infinisil

Context

Who to request for reviews on PRs can be specified on a per-file basis (using ci/OWNERS) and per-package basis (using meta.maintainers/meta.teams). Both of these already support specifying both individual users and teams: For ci/OWNERS via GitHub teams, and for meta.teams (very new, see #394797, #400458, #402991) with team-list.nix. Reviews are requested individually from each team member however.

Problem

  • Team membership needs to be managed in multiple places: Both in the GitHub team and the team-list.nix. This leads to membership often being desynchronised between the two.

  • Teams cannot make use of GitHub's advanced code review settings, such as round-robin assignment and more:

    Image

Proposal

  • Change the code review mechanisms to also request reviews directly from GitHub teams instead of just the individual members.
  • Do a one-time sync from team-list.nix to GitHub teams, creating missing teams and adding team members when necessary.
  • Deprecate the members field of team-list.nix and remove all remaining uses of it in Nixpkgs.
  • Change the code review mechanisms to only request reviews directly from GitHub teams instead of also the individual members.

Me and @balsoft will work to implement this. While there's some tricky implementation details, we don't expect this overall idea to be controversial, so we'll go ahead without any formal approval

CC @NixOS/nixpkgs-ci

Metadata

Metadata

Labels

0.kind: enhancementAdd something new or improve an existing system.6.topic: continuous integrationAffects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions