-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
First-class GitHub team support for review requests #447514
Copy link
Copy link
Labels
0.kind: enhancementAdd something new or improve an existing system.Add something new or improve an existing system.6.topic: continuous integrationAffects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub ActionsAffects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions
Metadata
Metadata
Labels
0.kind: enhancementAdd something new or improve an existing system.Add something new or improve an existing system.6.topic: continuous integrationAffects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub ActionsAffects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions
Fields
Give feedbackNo fields configured for issues without a type.
Context
Who to request for reviews on PRs can be specified on a per-file basis (using
ci/OWNERS) and per-package basis (usingmeta.maintainers/meta.teams). Both of these already support specifying both individual users and teams: Forci/OWNERSvia GitHub teams, and formeta.teams(very new, see #394797, #400458, #402991) withteam-list.nix. Reviews are requested individually from each team member however.Problem
Team membership needs to be managed in multiple places: Both in the GitHub team and the
team-list.nix. This leads to membership often being desynchronised between the two.Teams cannot make use of GitHub's advanced code review settings, such as round-robin assignment and more:
Proposal
team-list.nixto GitHub teams, creating missing teams and adding team members when necessary.membersfield ofteam-list.nixand remove all remaining uses of it in Nixpkgs.Me and @balsoft will work to implement this. While there's some tricky implementation details, we don't expect this overall idea to be controversial, so we'll go ahead without any formal approval
CC @NixOS/nixpkgs-ci