Skip to content

overrideAttrs on result of fetchFromGitHub does not re-add fields #444503

@ConnorBaker

Description

@ConnorBaker

As discovered with @djacu, using overrideAttrs on the derivation returned by fetchFromGitHub results in a derivation without the fields added after application of fetcher to fetcherArgs:

fetcher fetcherArgs
// {
meta = newMeta;
inherit owner repo tag;
rev = revWithTag;
}

One solution is to have both fetcher implementation accept variable arguments and pass through those which are not explicitly used; this would allow additional customization of the implementation, such as setting meta or env.

Metadata

Metadata

Assignees

Labels

0.kind: bugSomething is broken2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions