Skip to content

Patch gobjectIntrospection to use GI_GIR_PATH #32790

@lukateras

Description

@lukateras

Might reduce closure size.

/cc @jtojnar, @orivej

<jtojnar> the XDG_DATA_DIRS propagated by gobject-introspection are only used
	  during build time (the gir files are analogous to header files)
<jtojnar> the typelibs are analogous to libraries and are what is actually
	  needed during runtime  [03:01]
<jtojnar> Ideally, the XDG_DATA_DIRS with the gir files would not bleed into
	  the closure  [03:02]
<orivej> and this is the reason to move them to dev?
<jtojnar> yes  [03:03]
<jtojnar> but since the XDG_DATA_DIRS variable is used, the wrapGAppsHook will
	  often add them
<jtojnar> to the wrapper
<orivej> jtojnar: does moving them to dev help with the closure size? it looks
	 like make_gobject_introspection_find_gir_files will add them to
	 XDG_DATA_DIRS regardless, and then wrapGAppsHook will embed them into
	 the wrapper  [03:06]
<jtojnar> it does not, I think it is done more for ease of mind
<jtojnar> until we patch gobject-introspection to use a different variable
<jtojnar> orivej:
	  https://lists.gnu.org/archive/html/guix-devel/2014-05/msg00026.html
<orivej> jtojnar: how did you know that e.g. "pdfpc" needs gi for setup hook?
	 what that a compilation or a run time error?  [03:12]
<orivej> ...was that...
<jtojnar> a compilation error
<orivej> ok, let's merge the PR now, I hope to look into this detail later

Metadata

Metadata

Assignees

No one assigned

    Labels

    2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md6.topic: GNOMEGNOME desktop environment and its underlying platform6.topic: closure sizeThe final size of a derivation, including its dependencies
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions