-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Mark flaky NixOS tests #216828
Copy link
Copy link
Open
Labels
0.kind: bugSomething is brokenSomething is broken0.kind: enhancementAdd something new or improve an existing system.Add something new or improve an existing system.2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.mdhttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md6.topic: developer experiencenixpkgs development workflownixpkgs development workflow6.topic: nixosIssues or PRs affecting NixOS modules, or package usability issues specific to NixOSIssues or PRs affecting NixOS modules, or package usability issues specific to NixOS6.topic: testingTooling for automated testing of packages and modulesTooling for automated testing of packages and modules
Metadata
Metadata
Assignees
Labels
0.kind: bugSomething is brokenSomething is broken0.kind: enhancementAdd something new or improve an existing system.Add something new or improve an existing system.2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.mdhttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md6.topic: developer experiencenixpkgs development workflownixpkgs development workflow6.topic: nixosIssues or PRs affecting NixOS modules, or package usability issues specific to NixOSIssues or PRs affecting NixOS modules, or package usability issues specific to NixOS6.topic: testingTooling for automated testing of packages and modulesTooling for automated testing of packages and modules
Fields
Give feedbackNo fields configured for issues without a type.
Describe the bug
We have become accustomed to some tests failing every now and then.
Making sweeping changes is harder than necessary because we can't trust the outcomes of tests.
Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
Flaky tests can be marked as such, so that they can still be fixed and don't bog anyone down.
See also earlier short discussion:
Some requirements for the marking solution:
mapAttrsto set some tests to null (and only on Hydra)pkgs.nixosTestsattrset works the same regardless of flakiness statuspkgs.nixosTestsprints a warning when evaluation or running a known-flaky testAdditional context
Notify maintainers
Metadata
Please run
nix-shell -p nix-info --run "nix-info -m"and paste the result.