-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Tracking issue: remove overuses of with lib; #208242
Copy link
Copy link
Open
Labels
3.skill: sprintableA larger issue which is split into distinct actionable tasksA larger issue which is split into distinct actionable tasks5.scope: trackingLong-lived issue tracking long-term fixes or multiple sub-problemsLong-lived issue tracking long-term fixes or multiple sub-problems6.topic: architectureRelating to code and API architecture of NixpkgsRelating to code and API architecture of Nixpkgs
Description
Issue description
There are many overused with lib; expressions on Nixpkgs, especially on NixOS modules. As explained in this link, it is a problematic anti-pattern.
Steps to reproduce
rg "with lib;" or anything like that.
Technical details
Please run
nix-shell -p nix-info --run "nix-info -m"and paste the result.
- system:
"x86_64-linux" - host os:
Linux 5.15.83, NixOS, 23.05 (Stoat), 23.05.20221222.7ba7b45 - multi-user?:
yes - sandbox:
yes - version:
nix-env (Nix) 2.12.0 - nixpkgs:
/nix/var/nix/profiles/per-user/root/channels/nixos
References
https://nix.dev/anti-patterns/language#with-attrset-expression
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
3.skill: sprintableA larger issue which is split into distinct actionable tasksA larger issue which is split into distinct actionable tasks5.scope: trackingLong-lived issue tracking long-term fixes or multiple sub-problemsLong-lived issue tracking long-term fixes or multiple sub-problems6.topic: architectureRelating to code and API architecture of NixpkgsRelating to code and API architecture of Nixpkgs