Skip to content

Risk of conflicting symbols from abseil-cpp #185865

@tobim

Description

@tobim

Describe the bug

The way abseil-cpp is packaged is problematic in multiple ways. First, we don't set any of the options in https://github.com/abseil/abseil-cpp/blob/lts_2021_11_02/absl/base/options.h and risk ABI conflicts when compiling depending packages with different compilers or C++ standards.
Then the package versions in nixpkgs define the cxxStandard option, which opens up another angle for the same issue. As soon as we have the same abseil lts with a mix of C++ standards in a closure things will break.

Next Steps

I propose to #define ABSL_OPTION_USE_STD_ANY 0 for the currently packaged versions but switch to 1 with 2022-06-23 (#181672).
I'd also try to bump the default to the latest version instead of lingering on 2021-03-24.
My biggest problem is I don't have a lot of compute to spare so it would be great if someone can help with nixpkgs-review, espescially on darwin.

Notify maintainers

@andersk
@cpcloud because you added the cxxStandard option.

Metadata

Metadata

Assignees

No one assigned

    Labels

    0.kind: bugSomething is broken2.status: stalehttps://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions