You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a meta issue to track the changes that are required since we've merged #78430 (resulted in some channel blockers: #109252).
This is important for everything that is part of modulesClosure (allowMissing is now false):
# Determine the set of modules that we need to mount the root FS.modulesClosure=pkgs.makeModulesClosure{rootModules=config.boot.initrd.availableKernelModules++config.boot.initrd.kernelModules;kernel=modulesTree;firmware=firmware;allowMissing=false;};
But for missing firmware we only print a warning: 49130f9
Can break on uncommon architectures (AFAIK we only test AMD64 and AArch64 on Hydra)
Can break with a custom kernel configuration
Can break with existing configs (that include typos or modules that aren't available on $arch)
Potential improvements:
Should we add a NixOS option for allowMissing that defaults to false?
Reasoning for this idea: We can fix regressions on Hydra and users could contribute fixes for other architectures but we cannot consider all custom kernel configurations (and minimal kernel configs will miss a lot of modules!)
The error message is not great
Why does it suddenly fail and not before -> maybe we could/should add an explanation and instructions (or link to this issue)?
This is a meta issue to track the changes that are required since we've merged #78430 (resulted in some channel blockers: #109252).
This is important for everything that is part of
modulesClosure(allowMissingis nowfalse):But for missing firmware we only print a warning: 49130f9
Relevant commits:
Open/unresolved issues to consider:
Potential improvements:
allowMissingthat defaults tofalse?