Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: tweag/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: codeowners-determinism
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Oct 9, 2024

  1. workflows/codeowners: More determinism for baseBranch 

    Before this, it was possible to have this sequence:
- A commit is pushed, workflow is started
- The base branch is changed within a few seconds, another workflow is started
- Both workflows finally get to run, but since they both fetch the base
  branch from the API, they both check the same thing.

This commit fixes that by propagating the event info that triggered the
workflow into the script
    @infinisil
    infinisil committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    6ae82e5 View commit details
    Browse the repository at this point in the history

  2. ci/request-reviews: Check the fixed revision instead of the branch 

    Before it was possible to get this sequence:
- A commit is pushed, workflow is being started
- Another commit is pushed within a couple seconds, another workflow is
  being started
- Both workflows now check the state of the base branch, running the
  same check twice since the base branch points at the same commit

This fixes that problem by making it use the Git hash that actually
triggered the event.
    @infinisil
    infinisil committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    fe4ceaf View commit details
    Browse the repository at this point in the history
Loading