nixos/timesyncd: remove migration path dating back to 19.09

nikstur · nikstur · commit ccf0b1426fcd · 2025-10-08T16:05:41.000+02:00
Also remove the test that only tested this migration and nothing else
about systemd-timesyncd.
diff --git a/nixos/modules/system/boot/timesyncd.nix b/nixos/modules/system/boot/timesyncd.nix
@@ -74,17 +74,6 @@ in
       # This means that systemd-timesyncd needs to have NSS modules path in LD_LIBRARY_PATH. When systemd-resolved is disabled we still need to set
       # NSS module path so that systemd-timesyncd keeps using other NSS modules that are configured in the system.
       environment.LD_LIBRARY_PATH = config.system.nssModules.path;
-
-      preStart =
-        # workaround an issue of systemd-timesyncd not starting due to upstream systemd reverting their dynamic users changes
-        #  - https://github.com/NixOS/nixpkgs/pull/61321#issuecomment-492423742
-        #  - https://github.com/systemd/systemd/issues/12131
-        lib.optionalString (versionOlder config.system.stateVersion "19.09") ''
-          if [ -L /var/lib/systemd/timesync ]; then
-            rm /var/lib/systemd/timesync
-            mv /var/lib/private/systemd/timesync /var/lib/systemd/timesync
-          fi
-        '';
     };
 
     environment.etc."systemd/timesyncd.conf".text = ''
diff --git a/nixos/tests/all-tests.nix b/nixos/tests/all-tests.nix
@@ -1482,7 +1482,6 @@ in
   systemd-sysusers-immutable = runTest ./systemd-sysusers-immutable.nix;
   systemd-sysusers-mutable = runTest ./systemd-sysusers-mutable.nix;
   systemd-sysusers-password-option-override-ordering = runTest ./systemd-sysusers-password-option-override-ordering.nix;
-  systemd-timesyncd = runTest ./systemd-timesyncd.nix;
   systemd-timesyncd-nscd-dnssec = runTest ./systemd-timesyncd-nscd-dnssec.nix;
   systemd-user-linger = runTest ./systemd-user-linger.nix;
   systemd-user-tmpfiles-rules = runTest ./systemd-user-tmpfiles-rules.nix;
diff --git a/nixos/tests/systemd-timesyncd.nix b/nixos/tests/systemd-timesyncd.nix
