postgresql: enable tests on darwin

wolfgangwalther · wolfgangwalther · commit 9869d7f7466d · 2024-11-23T19:58:50.000+01:00
The tests were disabled in #62752. The problem is System Integrity Protection on macOS, which resets DYDL_LIBRARY_PATH and thus breaks the temporary installation of PostgreSQL. By running the checks *after* the installPhase, the libraries will already be available in the default locations.
diff --git a/pkgs/servers/sql/postgresql/generic.nix b/pkgs/servers/sql/postgresql/generic.nix
@@ -218,9 +218,13 @@ let
         wrapProgram $out/bin/initdb --prefix PATH ":" ${glibc.bin}/bin
       '';
 
-    doCheck = !stdenv'.hostPlatform.isDarwin;
-    # autodetection doesn't seem to able to find this, but it's there.
-    checkTarget = "check-world";
+    # Running tests as "install check" to work around SIP issue on macOS:
+    # https://www.postgresql.org/message-id/flat/4D8E1BC5-BBCF-4B19-8226-359201EA8305%40gmail.com
+    # Also see <nixpkgs>/doc/stdenv/platform-notes.chapter.md
+    doCheck = false;
+    # Tests just get stuck on macOS 14.x for v13 and v14
+    doInstallCheck = !(stdenv'.hostPlatform.isDarwin && olderThan "15");
+    installCheckTarget = "check-world";
 
     passthru = let
       this = self.callPackage generic args;
