Bloop: rework bloop packaging

karolchmist · Jon · commit 58f609160cd3 · 2020-07-28T11:36:42.000-07:00
* Include all completions
* Update derivation to make it similar to archlinux packaging
diff --git a/pkgs/development/tools/build-managers/bloop/default.nix b/pkgs/development/tools/build-managers/bloop/default.nix
@@ -1,81 +1,79 @@
-{ stdenv, fetchurl, coursier,
- autoPatchelfHook, 
- lib, zlib }:
+{ stdenv
+, fetchurl
+, coursier
+, autoPatchelfHook
+, lib
+, zlib
+}:
 
-let
-  baseName = "bloop";
+stdenv.mkDerivation rec {
+  pname = "bloop";
   version = "1.4.1";
 
-  client = stdenv.mkDerivation {
-    name = "${baseName}-client-${version}";
-
-    nativeBuildInputs = [ autoPatchelfHook ] ;
-    phases = [ "installPhase" "fixupPhase" ];
-    buildInputs = [ stdenv.cc.cc.lib zlib] ;
-
-    installPhase = ''
-      mkdir -p $out/bin
- 
-      export COURSIER_CACHE=$(pwd)
-      ${coursier}/bin/coursier install bloop:${version} \
-                               --repository "bintray:scalameta/maven" \
-                               --repository "bintray:scalacenter/releases" \
-                               --repository "https://oss.sonatype.org/content/repositories/staging" \
-                               --force \
-                               --install-dir $out
-    '';
-    
-    outputHashMode = "recursive";
-    outputHashAlgo = "sha256";
-    outputHash     = "01hgv0j0a4v8iqi638rcqdirpa30jwfp7gh7dvsk32apx003ylvb";
+  bloop-coursier-channel = fetchurl {
+    url = "https://github.com/scalacenter/bloop/releases/download/v${version}/bloop-coursier.json";
+    sha256 = "2e6a873183e5e22712913bfdab1331d0a7792167c369fee5be0c83e27572fe12";
   };
 
-  server = stdenv.mkDerivation {
-    name = "${baseName}-server-${version}";
-    buildCommand = ''
-      mkdir -p $out/bin
+  bloop-bash = fetchurl {
+    url = "https://github.com/scalacenter/bloop/releases/download/v${version}/bash-completions";
+    sha256 = "da6b7ecd4109bd0ff98b1c452d9dd9d26eee0d28ff604f6c83fb8d3236a6bdd1";
+  };
 
-      export COURSIER_CACHE=$(pwd)
-      ${coursier}/bin/coursier bootstrap ch.epfl.scala:bloop-frontend_2.12:${version} \
-                               --repository "bintray:scalameta/maven" \
-                               --repository "bintray:scalacenter/releases" \
-                               --repository "https://oss.sonatype.org/content/repositories/staging" \
-                               --deterministic \
-                               --force \
-                               --main bloop.Server \
-                               --output $out/blp-server
-    '';
-    outputHashMode = "recursive";
-    outputHashAlgo = "sha256";
-    outputHash     = "01kyzb374kyicm1nmx6vzz42gj8cd9m6bd5dgrajkcr6q09jfgbg";
+  bloop-fish = fetchurl {
+    url = "https://github.com/scalacenter/bloop/releases/download/v${version}/fish-completions";
+    sha256 = "1pa8h81l2498q8dbd83fzipr99myjwxpy8xdgzhvqzdmfv6aa4m0";
   };
 
-  zsh = stdenv.mkDerivation {
-    name = "${baseName}-zshcompletion-${version}";
+  bloop-zsh = fetchurl {
+    url = "https://github.com/scalacenter/bloop/releases/download/v${version}/zsh-completions";
+    sha256 = "1xzg0qfkjdmzm3mvg82mc4iia8cl7b6vbl8ng4ir2xsz00zjrlsq";
+  };
 
-    src = fetchurl {
-      url = "https://raw.githubusercontent.com/scalacenter/bloop/v${version}/etc/zsh/_bloop";
-      sha256 = "1xzg0qfkjdmzm3mvg82mc4iia8cl7b6vbl8ng4ir2xsz00zjrlsq";
-    };
+  bloop-coursier = stdenv.mkDerivation {
+    name = "${pname}-coursier-${version}";
 
     phases = [ "installPhase" ];
+    installPhase = ''
+      export COURSIER_CACHE=$(pwd)
+      export COURSIER_JVM_CACHE=$(pwd)
+
+      mkdir channel
+      ln -s ${bloop-coursier-channel} channel/bloop.json
+      ${coursier}/bin/coursier install --install-dir $out --default-channels=false --channel channel --only-prebuilt=true bloop
+
+      # Remove binary part of the coursier launcher script to make derivation output hash stable
+      sed -i '5,$ d' $out/bloop
+   '';
 
-    installPhase = ''cp $src $out'';
+    outputHashMode = "recursive";
+    outputHashAlgo = "sha256";
+    outputHash     = "17jskljn0aspvl7s2hadzjmp05blnsrxi8db8pn3lfw40da4yn79";
   };
-in
-stdenv.mkDerivation {
-  name = "${baseName}-${version}";
 
-  phases = [ "installPhase" ];
+  nativeBuildInputs = [ autoPatchelfHook ] ;
+  phases = [ "installPhase" "fixupPhase" ];
+  buildInputs = [ stdenv.cc.cc.lib zlib ] ;
 
   installPhase = ''
+    export COURSIER_CACHE=$(pwd)
+    export COURSIER_JVM_CACHE=$(pwd)
+
     mkdir -p $out/bin
-    mkdir -p $out/share/zsh/site-functions
+    cp ${bloop-coursier}/bloop $out/bloop
+    cp ${bloop-coursier}/.bloop.aux $out/.bloop.aux
+    ln -s $out/bloop $out/bin/bloop
 
-    ln -s ${server}/blp-server $out/bin/blp-server
+    # patch the bloop launcher so that it works when symlinked
+    sed "s|\$(dirname \"\$0\")|$out|" -i $out/bloop
 
-    ln -s ${zsh} $out/share/zsh/site-functions/_bloop
-    ln -s ${client}/.bloop.aux $out/bin/bloop
+    #Install completions
+    mkdir -p $out/etc/bash_completion.d
+    ln -s ${bloop-bash} $out/etc/bash_completion.d/bloop
+    mkdir -p $out/share/zsh/site-functions
+    ln -s ${bloop-zsh} $out/share/zsh/site-functions/_bloop
+    mkdir -p $out/usr/share/fish/vendor_completions.d/
+    ln -s ${bloop-fish} $out/usr/share/fish/vendor_completions.d/bloop.fish
   '';
 
   meta = with stdenv.lib; {
