x264: fix runtime crash due to llvm-strip args

reckenrode · reckenrode · commit 0f0b89fc7bce · 2023-12-01T09:56:29.000-05:00
This is a similar issue to #234868, but it crashes instead of failing to link. The same fix applies (using `-S` instead of `-x` with `llvm-strip`).
diff --git a/pkgs/development/libraries/x264/default.nix b/pkgs/development/libraries/x264/default.nix
@@ -28,6 +28,10 @@ stdenv.mkDerivation rec {
 
   postPatch = ''
     patchShebangs .
+  ''
+  # Darwin uses `llvm-strip`, which results in a crash at runtime in assembly-based routines when `-x` is specified.
+  + lib.optionalString stdenv.isDarwin ''
+    substituteInPlace Makefile --replace '$(if $(STRIP), $(STRIP) -x $@)' '$(if $(STRIP), $(STRIP) -S $@)'
   '';
 
   enableParallelBuilding = true;
