ci/request-reviews: Don't request reviews from non-repo-collaborators

infinisil · infinisil · commit 077007a65827 · 2025-01-03T04:32:38.000+01:00
Fixes this problem for maintainer-based reviews when the maintainer
didn't yet accept or missed the automated invite:

    gh: Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the NixOS/nixpkgs repository. (HTTP 422)
diff --git a/ci/request-reviews/process-reviewers.sh b/ci/request-reviews/process-reviewers.sh
@@ -47,6 +47,16 @@ while read -r user; do
     fi
 done < "$tmp/already-reviewed-by"
 
+for user in "${!users[@]}"; do
+    if ! gh api \
+        -H "Accept: application/vnd.github+json" \
+        -H "X-GitHub-Api-Version: 2022-11-28" \
+        "/repos/$baseRepo/collaborators/$user" >&2; then
+        log "User $user is not a repository collaborator, probably missed the automated invite to the maintainers team (see <https://github.com/NixOS/nixpkgs/issues/234293>), ignoring"
+        unset 'users[$user]'
+    fi
+done
+
 # Turn it into a JSON for the GitHub API call to request PR reviewers
 jq -n \
     --arg users "${!users[*]}" \
