Add deprecation warning for bare invocation of nixfmt#376
Merged
jfly merged 2 commits intoNixOS:masterfrom Mar 18, 2026
Merged
Conversation
Warning: Bare invocation of nixfmt is deprecated. Use 'nixfmt -' for anonymous stdin.
Contributor
MattSturgeon
left a comment
There was a problem hiding this comment.
Thanks for the quick PR!
I just have a couple minor nits w.r.t. the ANSI text formatting, otherwise diff SGTM. Tested locally, and the warning appears as intended.
$ echo '{ foo = "bar"; }' | result/bin/nixfmt -
{ foo = "bar"; }
$ echo '{ foo = "bar"; }' | result/bin/nixfmt
Warning: Bare invocation of nixfmt is deprecated. Use 'nixfmt -' for anonymous stdin.
{ foo = "bar"; }
Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>
Contributor
Author
|
I'll make a new PR with the error and warning stuff cleaned up, those escape codes are elsewhere in the repo I'll get em all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added warning:
Bare invocation of nixfmt is deprecated. Use 'nixfmt -' for anonymous stdin.This closes #301