Skip to content

Move url-name utility to libexpr/flake #9655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ericson2314 merged 2 commits into from
Dec 22, 2023
Merged

Move url-name utility to libexpr/flake #9655

Ericson2314 merged 2 commits into from
Dec 22, 2023

Conversation

@iFreilicht
Copy link
Contributor

@iFreilicht iFreilicht commented Dec 21, 2023

Motivation

As requested in #8678 (comment)

Context

See above

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@iFreilicht iFreilicht requested a review from edolstra as a code owner December 21, 2023 21:46
@github-actions github-actions bot added the new-cli Relating to the "nix" command label Dec 21, 2023
@iFreilicht iFreilicht mentioned this pull request Dec 21, 2023
Merged
12 tasks
bobvanderlinden
bobvanderlinden reviewed Dec 21, 2023
View reviewed changes
@iFreilicht iFreilicht force-pushed the move-flake-url-name-util branch from 7dfed4a to 6bfc9c1 Compare December 22, 2023 08:21
@iFreilicht iFreilicht force-pushed the move-flake-url-name-util branch from 6bfc9c1 to 26d7b0c Compare December 22, 2023 08:33
Ericson2314
Ericson2314 approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Ericson2314 Ericson2314 merged commit d65d56f into NixOS:master Dec 22, 2023
@iFreilicht iFreilicht deleted the move-flake-url-name-util branch December 22, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

+2 more reviewers

@roberth roberth roberth left review comments

@bobvanderlinden bobvanderlinden bobvanderlinden left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new-cli Relating to the "nix" command

Projects

Nix team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iFreilicht @roberth @Ericson2314 @bobvanderlinden