Closed
Conversation
Transitive dependencies (dependencies of inputs) should be considered part of that input, and any time the input is updated, those dependencies need to be updated to match the new upstream lockfile. What we have now is similar to the inconsistent state you end up in when you checkout a git revision without updating the submodules.
cole-h
reviewed
Sep 13, 2023
cole-h
reviewed
Sep 13, 2023
Co-authored-by: Cole Helbling <cole.e.helbling@outlook.com>
cole-h
reviewed
Sep 19, 2023
Member
cole-h
left a comment
There was a problem hiding this comment.
The code compiles now :P
but I can't comment on the correctness of the approach.
Contributor
Author
|
Ah okay, no worries |
This was referenced Jul 9, 2025
Merged
Member
|
Apologies for not looking into this sooner. I've made an updated PR (#13437) that also adds a test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transitive dependencies (dependencies of inputs) should be considered part of that input, and any time the input is updated, those dependencies need to be updated to match the new upstream lockfile.
What we have now is similar to the inconsistent state you end up in when you checkout a git revision without updating the submodules.
Motivation
see #8976