libstore/derivation-goal: Elaborate a TODO for performance concern#7307
Merged
thufschmitt merged 1 commit intoNixOS:masterfrom Jan 6, 2023
Merged
Conversation
Member
|
I actually don't think we want to implement that with lookups. That's some info that we should have, we only can't rely on it right now because the control-flow is impossible to understand. And if we have to rely on it, then we probably shouldn't cache it since we'd risk running into the same kind of problem that we've just solved here. |
Contributor
|
Discussed in Nix team meeting 2023-01-06:
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-01-06-nix-team-meeting-minutes-21/24573/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/NixOS/nix/pull/7283/files/c279ddb18cf3a34b0f6d4e3adcf9455da5397ad7#r1022993437