Improve 'waiting for' message by supplying a reason for the message#3577
Closed
balsoft wants to merge 3 commits intoNixOS:masterfrom
Closed
Improve 'waiting for' message by supplying a reason for the message#3577balsoft wants to merge 3 commits intoNixOS:masterfrom
balsoft wants to merge 3 commits intoNixOS:masterfrom
Conversation
This was referenced May 8, 2020
kirelagin
reviewed
May 8, 2020
Co-authored-by: Kirill Elagin <kirelagin@gmail.com>
yorickvP
reviewed
May 8, 2020
Contributor
yorickvP
left a comment
There was a problem hiding this comment.
Does this print the message at the same points in time as before?
Member
Author
|
No, not exactly. It prints those messages slightly earlier in the code -- right at the time when the wakeup is scheduled, whereas previously it was printed before the thread goes to sleep. However, it shouldn't be much of a difference (if I understand the execution path correctly). |
Member
|
Thanks, I've gone for a slightly different approach in 5ed5d7a (using |
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2069 by allowing to pass the reason for which we are waiting to
Worker::wait*functions.Implementation details: stores the latest reason for which some
DerivationGoalis sleeping inWorker, and if await*function is called with a reason different from the previous one, that reason is printed to stderr. Example output: