Skip to content

tests/functional/flakes/develop.sh: Add test for outputChecks stripping#14312

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
corngood:develop-structuredAttrs-fix
Oct 20, 2025
Merged

tests/functional/flakes/develop.sh: Add test for outputChecks stripping#14312
Ericson2314 merged 1 commit intoNixOS:masterfrom
corngood:develop-structuredAttrs-fix

Conversation

@corngood
Copy link
Copy Markdown
Contributor

Motivation

Follow up from #14306

Context

I thought about looping over the whole test suite and testing with and without __structuredAttrs, but most of the tests have to do with the basic mechanics of nix develop, so that seemed like overkill.

@corngood corngood requested a review from edolstra as a code owner October 20, 2025 22:19
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Oct 20, 2025
@corngood
Copy link
Copy Markdown
Contributor Author

I verified that it fails with and without __structuredAttrs when the stripping code is removed.

Copy link
Copy Markdown
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Ericson2314 Ericson2314 enabled auto-merge October 20, 2025 22:41
@Ericson2314 Ericson2314 added this pull request to the merge queue Oct 20, 2025
Merged via the queue into NixOS:master with commit 2a2bb83 Oct 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants