meson: refactor nix_soversion into nix-meson-build-support/common#14001
Merged
Mic92 merged 1 commit intoNixOS:masterfrom Sep 16, 2025
Merged
meson: refactor nix_soversion into nix-meson-build-support/common#14001Mic92 merged 1 commit intoNixOS:masterfrom
Mic92 merged 1 commit intoNixOS:masterfrom
Conversation
This is a follow-on to NixOS#13995 which added soversion to the libraries
Contributor
Author
|
(https://koji.fedoraproject.org/koji/taskinfo?taskID=137166744 is a Fedora Rawhide test build) |
Mic92
approved these changes
Sep 16, 2025
keszybz
reviewed
Sep 16, 2025
| endif | ||
|
|
||
| # Darwin ld doesn't like "X.Y.Zpre" | ||
| nix_soversion = meson.project_version().strip('pre') |
Contributor
There was a problem hiding this comment.
This strips any of p, r, e at the end of the string. In other words, `s/^[pre]+//; s/[pre]+$//'. This will work, though it might be a bit surprising in some contexts.
Contributor
Author
There was a problem hiding this comment.
Ahh - oh thanks for mentioning that - okay I will switch back to .replace() then...
(there used to be .remove_suffix() but no more apparently)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-on to #13995 which added nix version soversion to the libraries.
A code cleanup to have a common
nix_soversiondefined in nix-meson-build-support,suggested by @xokdvium in #13995 (review)