Merged
Conversation
xokdvium
reviewed
Aug 26, 2025
93a1acd to
12192de
Compare
I need this for some `ParseURL` improvements, but I figure this is better to send as its own PR. I changed the tests willy-nilly to sometimes use `std::list<std::string_view>` instead of `Strings` (which is `std::list<std::string>`). Co-Authored-By: Sergei Zimmerman <sergei@zimmerman.foo>
12192de to
cc4aa70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need this for some
ParseURLimprovements, but I figure this is better to send as its own PR.I changed the tests willy-nilly to sometimes use
std::list<std::string_view>instead ofStrings(which isstd::list<std::string>),Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.