Implement parseURLRelative, use in HttpBinaryCacheStore#13819
Merged
xokdvium merged 1 commit intoNixOS:masterfrom Aug 27, 2025
Merged
Implement parseURLRelative, use in HttpBinaryCacheStore#13819xokdvium merged 1 commit intoNixOS:masterfrom
parseURLRelative, use in HttpBinaryCacheStore#13819xokdvium merged 1 commit intoNixOS:masterfrom
Conversation
xokdvium
reviewed
Aug 24, 2025
Contributor
xokdvium
left a comment
There was a problem hiding this comment.
Some minor notes. Would be great to have a bit more tests but otherwise LGTM. The merging algorithm should do exactly what we want for this logic: https://datatracker.ietf.org/doc/html/rfc3986#section-5.2.2.
xokdvium
reviewed
Aug 24, 2025
f18ede4 to
88ae4a6
Compare
88ae4a6 to
10837e7
Compare
451aa6f to
cf3f40c
Compare
Ericson2314
commented
Aug 25, 2025
| /* Hack: Boost `url_view` supports Zone IDs, but `url` does not. | ||
| Just manually take the authority from the original URL to work | ||
| around it. See https://github.com/boostorg/url/issues/919 for | ||
| details. */ |
0d540fc to
03637d4
Compare
xokdvium
reviewed
Aug 25, 2025
03637d4 to
15d28ce
Compare
15d28ce to
d31c796
Compare
vinniefalco
reviewed
Aug 26, 2025
vinniefalco
reviewed
Aug 26, 2025
d31c796 to
1dc682b
Compare
xokdvium
reviewed
Aug 26, 2025
1dc682b to
ef2c0cf
Compare
xokdvium
reviewed
Aug 26, 2025
ef2c0cf to
852c43a
Compare
xokdvium
reviewed
Aug 26, 2025
xokdvium
reviewed
Aug 26, 2025
xokdvium
reviewed
Aug 26, 2025
852c43a to
8d29629
Compare
This allows us to replace some very hacky and not correct string concatentation in `HttpBinaryCacheStore`. It will especially be useful with NixOS#13752, when today's hacks started to cause problems in practice, not just theory. Also make `fixGitURL` returned a `ParsedURL`.
8d29629 to
e82210b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This allows us to replace some very hacky and not correct string concatentation in
HttpBinaryCacheStore.Also make
fixGitURLreturned aParsedURL.Context
It will especially be useful with #13752, when today's hacks started to cause problems in practice, not just theory.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.