libutil: Fix handling of unescaped spaces, quotes and shevrons in queries and fragments#13773
Merged
Mic92 merged 1 commit intoNixOS:masterfrom Aug 17, 2025
Merged
libutil: Fix handling of unescaped spaces, quotes and shevrons in queries and fragments#13773Mic92 merged 1 commit intoNixOS:masterfrom
Mic92 merged 1 commit intoNixOS:masterfrom
Conversation
…ries and fragments Turns out we didn't have tests for some of the important behavior introduced for flake reference fragments and url queries [1]. This is rather important and is relied upon by existing tooling. This fixes up these exact cases before handing off the URL to the Boost.URL parser. To the best of my knowledge this implements the same behavior as prior regex-based parser did [2]: > fragmentRegex = "(?:" + pcharRegex + "|[/? \"^])*"; > queryRegex = "(?:" + pcharRegex + "|[/? \"])*"; [1]: 9c0a09f [2]: https://github.com/NixOS/nix/blob/2.30.2/src/libutil/include/nix/util/url-parts.hh
Contributor
Author
|
cc @NobbZ |
Contributor
|
Yeah, this seems to fix the issue I have. |
Mic92
approved these changes
Aug 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Turns out we didn't have tests for some of the important behavior introduced for flake reference fragments and url queries 1. This is rather important and is relied upon by existing tooling. This fixes up these exact cases before handing off the URL to the Boost.URL parser.
To the best of my knowledge this implements the same behavior as prior regex-based parser did 2:
Context
Fixes #13772. Thankfully we didn't have a release with this refactoring yet.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.