Inline printHash16or32 and remove redundant helper#13716
Merged
Ericson2314 merged 4 commits intoNixOS:masterfrom Aug 8, 2025
Merged
Inline printHash16or32 and remove redundant helper#13716Ericson2314 merged 4 commits intoNixOS:masterfrom
Ericson2314 merged 4 commits intoNixOS:masterfrom
Conversation
Ericson2314
reviewed
Aug 8, 2025
Co-authored-by: John Ericson <git@JohnEricson.me>
xokdvium
reviewed
Aug 8, 2025
Co-authored-by: Sergei Zimmerman <sergei@zimmerman.foo>
Ericson2314
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
printHash16or32 was only used in
nix-prefetch-url. Removing it and inlining the logic simplifies the code.Context
This addresses issue #13692.
As discussed, we inline the hash formatting logic directly at the call site. This simplifies the codebase by eliminating a redundant helper function. And also preserves the MD5 behavior.
At first, I considered keeping a generic function, but it ended up feeling redundant.
The main logic is now inlined directly into
nix-prefetch-url. Reviewers can focus on verifying that the inlined logic preserves the old behavior for MD5 hashes.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.