Move some MixStoreDirMethods members to the right .cc file#13705
Merged
xokdvium merged 1 commit intoNixOS:masterfrom Aug 7, 2025
Merged
Move some MixStoreDirMethods members to the right .cc file#13705xokdvium merged 1 commit intoNixOS:masterfrom
MixStoreDirMethods members to the right .cc file#13705xokdvium merged 1 commit intoNixOS:masterfrom
Conversation
43c7cb4 to
07edd62
Compare
I had not wanted to cause unncessary churn before, but now that we've bitten the bullet with the Big Reformat, I feel it is the right time. Future readers will appreciate that the declarations and definitions files are one-to-one as they should be, and `store-api.cc` is good to shrink in any event. I don't think there are outstanding PRs changing this code either. (I had some for a while, but they are all merged.)
07edd62 to
e074406
Compare
xokdvium
approved these changes
Aug 7, 2025
Contributor
xokdvium
left a comment
There was a problem hiding this comment.
Trivial code move with --color-moved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Future readers will appreciate that the declarations and definitions files are one-to-one as they should be, and
store-api.ccis good to shrink in any event.Context
I had not wanted to cause unnecessary churn before, but now that we've bitten the bullet with the Big Reformat, I feel it is the right time.
I don't think there are outstanding PRs changing this code either. (I had some for a while, but they are all merged.)
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.