Slight clean up the constructors for Hash#13704
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Aug 7, 2025
Merged
Conversation
27732a1 to
000a827
Compare
- No more private constructor that is kinda weird - Two new static functions, `baseFromSize` and `baseFromSize`, that do one thing, and one thing only (simple). - Two `Hash::parse*` that previously used the private constructor now can use these two functions directly. - The remaining `Hash::parseAny*` methods, which are inherently more complex, are written in terms of a `parseAnyHelper` static function which is also complex, but keeps the complexity in one spot.
000a827 to
9d8d8df
Compare
xokdvium
approved these changes
Aug 7, 2025
Contributor
xokdvium
left a comment
There was a problem hiding this comment.
Can be iterated on in follow-ups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No more private constructor that is kinda weird
Two new static functions,
baseFromSizeandbaseFromSize, that do one thing, and one thing only (simple).Two
Hash::parse*that previously used the private constructor now can use these two functions directly.The remaining
Hash::parseAny*methods, which are inherently more complex, are written in terms of aparseAnyHelperstatic function which is also complex, but keeps the complexity in one spot.Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.