Base64 trailing test (from Snix, thanks)#13697
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Aug 6, 2025
Merged
Conversation
flokli
approved these changes
Aug 6, 2025
d935e3c to
ead7954
Compare
|
🎉 All dependencies have been resolved ! |
xokdvium
approved these changes
Aug 6, 2025
Contributor
xokdvium
left a comment
There was a problem hiding this comment.
Having more tests around these tricky back-compat landmines is great. The licensing situation seems to have been also figured out, so LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@flokli wrote the original test
Context
depends on #13693
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.