tests/nixos: Parametrize on the system#13572
Merged
roberth merged 1 commit intoNixOS:masterfrom Jul 29, 2025
Merged
Conversation
All of the existing tests only run on x86_64-linux and the whole `nixpkgsFor` makes it hard to reuse those for e.g. running the nixos tests with a sanitizer build of nix. This rips off the bandaid and removes the `nixpkgsFor` parameter in favor of a single instance of nixpkgs with a separate `nixComponents`.
roberth
approved these changes
Jul 29, 2025
Member
roberth
left a comment
There was a problem hiding this comment.
Agreed.
Tested by evaluating. echo >>flake.nix so that no rev is appended to package versions. Then hydraJobs.tests.functional_user.drvPath evaluates to the same derivation before and after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
All of the existing tests only run on x86_64-linux and the whole
nixpkgsFormakes it hard to reuse those for e.g. running the nixos tests with a sanitizer build of nix. This rips off the bandaid and removes thenixpkgsForparameter in favor of a single instance of nixpkgs with a separatenixComponents.Context
Progress towards reducing the usage of overlays and
nixpkgsFor(cc @roberth)Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.