Skip to content

Clear displayPrefix in makeEmptySourceAccessor (backport #13296)#13317

Merged
mergify[bot] merged 1 commit into2.28-maintenancefrom
mergify/bp/2.28-maintenance/pr-13296
Jul 11, 2025
Merged

Clear displayPrefix in makeEmptySourceAccessor (backport #13296)#13317
mergify[bot] merged 1 commit into2.28-maintenancefrom
mergify/bp/2.28-maintenance/pr-13296

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jun 2, 2025

Motivation

Judging by the comment for makeEmptySourceAccessor the prefix has to be empty:

Return a source accessor that contains only an empty root directory.

Context

Fixes #13295.

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

This is an automatic backport of pull request #13296 done by [Mergify](https://mergify.com).

@mergify mergify bot added automatic backport This PR is a backport produced by automation (does not trigger backporting) merge-queue labels Jun 2, 2025
@mergify mergify bot requested a review from edolstra as a code owner June 2, 2025 23:34
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Jun 2, 2025
@Mic92 Mic92 force-pushed the mergify/bp/2.28-maintenance/pr-13296 branch from f8b021c to 4cd68d1 Compare June 3, 2025 17:29
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Jun 3, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@roberth
Copy link
Copy Markdown
Member

roberth commented Jun 23, 2025

Can't reproduce the vm_tests failure.
Could be detsys action adjacent, @edolstra?

@xokdvium
Clear displayPrefix in makeEmptySourceAccessor
8f88774 
Judging by the comment for `makeEmptySourceAccessor` the prefix has
to be empty:

> Return a source accessor that contains only an empty root directory.

Fixes #13295.

(cherry picked from commit fba1bb0)
@xokdvium xokdvium force-pushed the mergify/bp/2.28-maintenance/pr-13296 branch from 4cd68d1 to 8f88774 Compare July 11, 2025 21:13
@mergify mergify bot merged commit 5ebe8b8 into 2.28-maintenance Jul 11, 2025
27 checks passed
@mergify mergify bot deleted the mergify/bp/2.28-maintenance/pr-13296 branch July 11, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

Assignees

@edolstra edolstra

Labels

automatic backport This PR is a backport produced by automation (does not trigger backporting) merge-queue with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roberth @edolstra @xokdvium