Skip to content

Move exportReferencesGraph to DerivationOptions#13024

Merged
Mic92 merged 3 commits intoNixOS:masterfrom
obsidiansystems:derivation-options-exportReferencesGraph
Apr 15, 2025
Merged

Move exportReferencesGraph to DerivationOptions#13024
Mic92 merged 3 commits intoNixOS:masterfrom
obsidiansystems:derivation-options-exportReferencesGraph

Conversation

@Ericson2314
Copy link
Copy Markdown
Member

Motivation

Preparing the way for #10760, and the issues it addresses.

Progress on #9846

Context

Depends on #13022

Tests are updated accordingly.


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

`CONTENT_ADDRESSED` -> `NIX_TESTS_CA_BY_DEFAULT`
Now, both the unit and functional tests relating to derivation options
are tested both ways -- with input addressing and content-addressing
derivations.
Tests are updated accordingly.
@Ericson2314 Ericson2314 requested a review from edolstra as a code owner April 14, 2025 18:34
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Apr 14, 2025
@dpulls
Copy link
Copy Markdown

dpulls bot commented Apr 15, 2025

🎉 All dependencies have been resolved !

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Apr 15, 2025

@Mergifyio rebase

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 15, 2025

rebase

❌ Pull request can't be updated with latest base branch changes

Details

Mergify needs the author permission to update the base branch of the pull request.
@Ericson2314 needs to authorize modification on its head branch.

@Mic92 Mic92 merged commit 13a0853 into NixOS:master Apr 15, 2025
12 checks passed
@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Apr 15, 2025

@Ericson2314 would it be possible to open pull requests not from your company fork but from nix directly? I don't have permissions to rebase branches otherwise.

@Ericson2314 Ericson2314 deleted the derivation-options-exportReferencesGraph branch April 15, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants