Rename FlakeCache to InputCache and move it to libfetchers#12992
Merged
Mic92 merged 4 commits intoNixOS:masterfrom Apr 15, 2025
Merged
Rename FlakeCache to InputCache and move it to libfetchers#12992Mic92 merged 4 commits intoNixOS:masterfrom
Mic92 merged 4 commits intoNixOS:masterfrom
Conversation
Ericson2314
previously requested changes
Apr 12, 2025
Member
Ericson2314
left a comment
There was a problem hiding this comment.
I am very happy to see functionality move from libflakes to libfetchers like this, but I don't want there to be a new global variable. Because there is no global fetchers::Settings in libfetchers, I don't think it is even correct to have such a global variable.
If the purpose of this is fetchTree then I think it is better to have one of these two alternatives:
EvalStateowns afetchers::InputCache. SeparateEvalStatesmaintain their own cache.EvalStatehas a references to afetchers::InputCache, andlibcmdhas a global variable, just like it has global variables forfetch::SettingsandEvalSettings(seesrc/libcmd/common-eval-args.cc).getEvalStatehooks up everything properly.
Member
Author
|
@Ericson2314 Okay, the |
Member
|
Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
InputCacheis now keyed onInputsrather thanFlakeRefs. This prepares it to be used byfetchTree(in a future PR).Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.