Skip to content

lookupInFlakeCache(): Fix O(n) time lookup#12038

Merged
edolstra merged 3 commits intoNixOS:masterfrom
DeterminateSystems:flake-cache
Dec 16, 2024
Merged

lookupInFlakeCache(): Fix O(n) time lookup#12038
edolstra merged 3 commits intoNixOS:masterfrom
DeterminateSystems:flake-cache

Conversation

@edolstra
Copy link
Copy Markdown
Member

@edolstra edolstra commented Dec 10, 2024

Motivation

This makes FlakeRef and Input comparable so they can be used as keys in an std::map. It also makes FetchedFlake a struct instead of an std::pair.

Context

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@github-actions github-actions bot added the fetching Networking with the outside (non-Nix) world, input locking label Dec 10, 2024
@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Dec 14, 2024

@mergify rebase

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 14, 2024

rebase

❌ Pull request can't be updated with latest base branch changes

Details

Mergify needs the author permission to update the base branch of the pull request.
@DeterminateSystems needs to authorize modification on its head branch.

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Dec 14, 2024 •
edited
Loading

@edolstra would it possible to use the nix repository instead of determinate systems fork? This way, we have the permission to rebase pull requests i.e. to fix CI.

@roberth
Copy link
Copy Markdown
Member

roberth commented Dec 16, 2024

I now use my personal fork for most changes, but also NixOS/nix branches in some cases where I'd like to collaborate more directly, but they're largely equivalent in terms of permissions. (Just no installer tests in personal fork branches)

@edolstra
Copy link
Copy Markdown
Member Author

edolstra commented Dec 16, 2024

@Mic92 I'll see if I can enable maintainer edits on our fork.

@edolstra edolstra merged commit f8eb2f6 into NixOS:master Dec 16, 2024
@edolstra edolstra deleted the flake-cache branch December 16, 2024 14:28
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Dec 16, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-12-16-nix-team-meeting-minutes-203/57483/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@roberth roberth roberth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fetching Networking with the outside (non-Nix) world, input locking

Projects

Nix team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edolstra @Mic92 @roberth @nixos-discourse