refactor(treewide): make some move ctors noexcept where appropriate#11846
Merged
Mic92 merged 1 commit intoNixOS:masterfrom Nov 9, 2024
xokdvium:dev/noexcept-more-ctors-where-possible
Merged
refactor(treewide): make some move ctors noexcept where appropriate#11846Mic92 merged 1 commit intoNixOS:masterfrom xokdvium:dev/noexcept-more-ctors-where-possible
Mic92 merged 1 commit intoNixOS:masterfrom
xokdvium:dev/noexcept-more-ctors-where-possible
Conversation
This is good practice to avoid pessimisations. Left comments for the reasoning why ctors should be noexcept. There are some tricky cases where we intentionally want throwing move ctors/assignments. But those cases should really be reviewed, since some of those can be replaced with more idiomatic copy/move-and-swap.
Mic92
approved these changes
Nov 9, 2024
Member
|
@mergify queue |
Contributor
🛑 The pull request has been merged manuallyDetailsThe pull request has been merged manually at 6e55f2c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is good practice to avoid pessimisations.
Left comments for the reasoning why ctors should be noexcept. There are some tricky cases where we intentionally want throwing move ctors/assignments. But those cases should really be reviewed, since some of those can be replaced with more idiomatic copy/move-and-swap.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.