warn-large-path-threshold: define 0 as number to disable warnings#11726
warn-large-path-threshold: define 0 as number to disable warnings#11726edolstra merged 1 commit intoNixOS:masterfrom
Conversation
|
cc @roberth as discussed yesterday. |
a61a2f9 to
0748348
Compare
|
Mhm. I am still getting a -1 in |
|
Ah. This is because it uses the nix from the build dependencies... |
|
"0" was intended as the "log all paths" value, but since we're talking about NARs, which are always bigger than 0 bytes, I guess it's not a problem.
That's wrong, maybe it's a regression in the new build system? Nix shouldn't depend on Nix. |
Maybe in a cross build, but that's not implemented afaik. |
Here it is: Line 7 in 79bbb4a |
Setting it to 1, should still allow this use case. I added this to the doc string. |
the default int64_t max was still overflowing for me, when this was dumped as json (noticed during building the manual). So making 0, the default and define it as "no warnings" fixes the situtation. Also it's much more human-readable in documentation.
0748348 to
e1834f4
Compare
the default int64_t max was still overflowing for me, when this was dumped as json (noticed during building the manual). So making 0, the default and define it as "no warnings" fixes the situtation. Also it's much more human-readable in documentation.
Motivation
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.