Merged
Conversation
tomberek
approved these changes
Jul 22, 2024
Member
|
Thank you! I took a look a week or two ago and I guess I was investigating in the wrong direction, because my failed attempt was much less clean 😆 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-07-22-nix-team-meeting-minutes-163/49544/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The nix cli should allow aliases to be used as flags. Examples:
--max-jobshas an alias--build-max-jobs--keep-derivationshas an alias--gc-keep-derivations--sandboxhas an alias--build-use-sandboxContext
Fixes #10989
Per the issue, the nix CLI should allow aliases to be used as flags. Currently, the cli prevents this and throws an unrecognized error. Looks like this behavior was implemented but not enabled so I've added some very small changes to
BaseSettings<T>,BaseSettings<bool>, andBaseSettings<SandboxMode>to fix this.Also added 2 tests to make sure all 3 types work.
Example from the issue works now:
Also returns the same error:
Feel free to close if this behavior isn't desired.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.