Skip to content

[Backport 2.20-maintenance] Fix adding symlink to the sandbox paths#10471

Merged
thufschmitt merged 2 commits into2.20-maintenancefrom
backport-10456-to-2.20-maintenance
Apr 11, 2024
Merged

[Backport 2.20-maintenance] Fix adding symlink to the sandbox paths#10471
thufschmitt merged 2 commits into2.20-maintenancefrom
backport-10456-to-2.20-maintenance

Conversation

@github-actions
Copy link
Copy Markdown

Automatic backport to 2.20-maintenance, triggered by a label in #10456.

Théophane Hufschmitt and others added 2 commits April 11, 2024 12:19
Regression test for #9579

(cherry picked from commit 872d93e)
…o a symlink out of the store

Bind-mounting symlinks is apparently not possible, which is why the
thing was failing.

Fortunately, symlinks are small, so we can fallback to copy them at no cost.

Fix #9579

Co-authored-by: Artturin <Artturin@artturin.com>
(cherry picked from commit 913db9f)
@thufschmitt thufschmitt reopened this Apr 11, 2024
@thufschmitt thufschmitt enabled auto-merge April 11, 2024 12:24
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Apr 11, 2024
@Ericson2314
Copy link
Copy Markdown
Member

Need backports of #10362 for this. I kicked that off. (It doesn't make a breaking change to Nix's headers so it should be OK.)

@thufschmitt
Copy link
Copy Markdown
Member

Dropped the last commit, should be good now

@thufschmitt thufschmitt merged commit 1cf8c57 into 2.20-maintenance Apr 11, 2024
@thufschmitt thufschmitt deleted the backport-10456-to-2.20-maintenance branch April 11, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants