-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Split utils.hh #8913
Copy link
Copy link
Closed
Labels
contributor-experienceDeveloper experience for Nix contributorsDeveloper experience for Nix contributorsgood first issueQuick win for first-time contributorsQuick win for first-time contributorsidea approvedThe given proposal has been discussed and approved by the Nix team. An implementation is welcome.The given proposal has been discussed and approved by the Nix team. An implementation is welcome.windows
Metadata
Metadata
Assignees
Labels
contributor-experienceDeveloper experience for Nix contributorsDeveloper experience for Nix contributorsgood first issueQuick win for first-time contributorsQuick win for first-time contributorsidea approvedThe given proposal has been discussed and approved by the Nix team. An implementation is welcome.The given proposal has been discussed and approved by the Nix team. An implementation is welcome.windows
Fields
Give feedbackNo fields configured for issues without a type.
utils.hhcurrently contains a mix of pure functions (e.g.tokenizeString) and functions to deal with the operating system (file descriptors, filesystem, signals etc.). It is also quite large.It should be split up by topic, and downstream files should only
#includethe pats they need.See also #8901. I already started splitting it up in that, to avoid a sea of CPP. But the right order in which to do things is to split it up first.