-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
rsync should be required in nix-manual meson.build #13313
Copy link
Copy link
Closed
Labels
good first issueQuick win for first-time contributorsQuick win for first-time contributorsidea approvedThe given proposal has been discussed and approved by the Nix team. An implementation is welcome.The given proposal has been discussed and approved by the Nix team. An implementation is welcome.
Metadata
Metadata
Assignees
Labels
good first issueQuick win for first-time contributorsQuick win for first-time contributorsidea approvedThe given proposal has been discussed and approved by the Nix team. An implementation is welcome.The given proposal has been discussed and approved by the Nix team. An implementation is welcome.
Fields
Give feedbackNo fields configured for issues without a type.
Description of the problem
When building the
nix-manualmeson subproject a custom target is defined using a shell script that invokes rsync. Despite that, rsync is never required by meson and configuration still succeeds if no rsync is on the system.nix/doc/manual/meson.build
Line 87 in 8676734
Suggested solution
Add a
find_program('rsync', required: true, native: true)to the meson.build