Keep track of the exact build start/stop times

edolstra · edolstra · commit b07060688a29 · 2016-12-07T16:09:38.000+01:00
diff --git a/src/libstore/build.cc b/src/libstore/build.cc
@@ -1347,6 +1347,7 @@ void DerivationGoal::tryToBuild()
             case rpAccept:
                 /* Yes, it has started doing so.  Wait until we get
                    EOF from the hook. */
+                result.startTime = time(0); // inexact
                 state = &DerivationGoal::buildDone;
                 return;
             case rpPostpone:
@@ -1424,6 +1425,7 @@ void DerivationGoal::buildDone()
     debug(format("builder process for ‘%1%’ finished") % drvPath);
 
     result.timesBuilt++;
+    result.stopTime = time(0);
 
     /* So the child is gone now. */
     worker.childTerminated(this);
@@ -2108,6 +2110,8 @@ void DerivationGoal::startBuilder()
     /* Create a pipe to get the output of the builder. */
     builderOut.create();
 
+    result.startTime = time(0);
+
     /* Fork a child to build the package. */
 #if __linux__
     if (useChroot) {
diff --git a/src/libstore/store-api.hh b/src/libstore/store-api.hh
@@ -218,7 +218,9 @@ struct BuildResult
        non-determinism.) */
     bool isNonDeterministic = false;
 
-    //time_t startTime = 0, stopTime = 0;
+    /* The start/stop times of the build (or one of the rounds, if it
+       was repeated). */
+    time_t startTime = 0, stopTime = 0;
 
     bool success() {
         return status == Built || status == Substituted || status == AlreadyValid;
diff --git a/src/nix-store/nix-store.cc b/src/nix-store/nix-store.cc
@@ -961,7 +961,7 @@ static void opServe(Strings opFlags, Strings opArgs)
                 out << status.status << status.errorMsg;
 
                 if (GET_PROTOCOL_MINOR(clientVersion) >= 3)
-                    out << status.timesBuilt << status.isNonDeterministic;
+                    out << status.timesBuilt << status.isNonDeterministic << status.startTime << status.stopTime;
 
                 break;
             }

Original file line number	Diff line number	Diff line change
`@@ -961,7 +961,7 @@ static void opServe(Strings opFlags, Strings opArgs)`
`961`	`961`	`out << status.status << status.errorMsg;`
`962`	`962`
`963`	`963`	`if (GET_PROTOCOL_MINOR(clientVersion) >= 3)`
`964`		`- out << status.timesBuilt << status.isNonDeterministic;`
	`964`	`+ out << status.timesBuilt << status.isNonDeterministic << status.startTime << status.stopTime;`
`965`	`965`
`966`	`966`	`break;`
`967`	`967`	`}`