fix(libutil/posix-source-accessor.cc): get rid of use-after-move bug

xokdvium · xokdvium · commit 3e0129ce3b9e · 2024-11-08T16:07:45.000+03:00
Naming class member variables the same as constructor arguments is a very
slippery slope because of how member variable names get resolved. Compiler
is not very helpful here and we need static analysis to forbid this kind of
stuff.

The following example illustrates the cause quite well:

```cpp

struct B {
    B(int) {}
};

struct A {
    A(int b): b([&amp;](){
        return b;
        static_assert(std::is_same_v&lt;decltype(b), int&gt;);
    }()) {
       static_assert(std::is_same_v&lt;decltype(b), int&gt;);
    }
    void member() {
        static_assert(std::is_same_v&lt;decltype(b), B&gt;);
    }
    B b;
};

int main() {
    A(1).member();
}
```

From N4861 6.5.1 Unqualified name lookup:

&gt; In all the cases listed in [basic.lookup.unqual], the scopes are searched
&gt; for a declaration in the order listed in each of the respective categories;
&gt; name lookup ends as soon as a declaration is found for the name.
&gt; If no declaration is found, the program is ill-formed.

In the affected code there was a use-after-move for all accesses in the constructor
body, but this UB wasn't triggered.

These types of errors are trivial to catch via clang-tidy's [clang-analyzer-cplusplus.Move].
diff --git a/src/libutil/posix-source-accessor.cc b/src/libutil/posix-source-accessor.cc
@@ -7,8 +7,8 @@
 
 namespace nix {
 
-PosixSourceAccessor::PosixSourceAccessor(std::filesystem::path && root)
-    : root(std::move(root))
+PosixSourceAccessor::PosixSourceAccessor(std::filesystem::path && argRoot)
+    : root(std::move(argRoot))
 {
     assert(root.empty() || root.is_absolute());
     displayPrefix = root.string();

Original file line number	Diff line number	Diff line change
`@@ -7,8 +7,8 @@`
`7`	`7`
`8`	`8`	`namespace nix {`
`9`	`9`
`10`		`-PosixSourceAccessor::PosixSourceAccessor(std::filesystem::path && root)`
`11`		`- : root(std::move(root))`
	`10`	`+PosixSourceAccessor::PosixSourceAccessor(std::filesystem::path && argRoot)`
	`11`	`+ : root(std::move(argRoot))`
`12`	`12`	`{`
`13`	`13`	`assert(root.empty() \|\| root.is_absolute());`
`14`	`14`	`displayPrefix = root.string();`