Another attempt at getting pseudoterminals to work on macOS

edolstra · edolstra · commit 3cc1125595d9 · 2019-06-17T08:08:04.000+02:00
diff --git a/src/libstore/build.cc b/src/libstore/build.cc
@@ -2196,6 +2196,9 @@ void DerivationGoal::startBuilder()
 
         if (chown(slaveName.c_str(), buildUser->getUID(), 0))
             throw SysError("changing owner of pseudoterminal slave");
+    } else {
+        if (grantpt(builderOut.readSide.get()))
+            throw SysError("granting access to pseudoterminal slave");
     }
 
     #if 0

Original file line number	Diff line number	Diff line change
`@@ -2196,6 +2196,9 @@ void DerivationGoal::startBuilder()`
`2196`	`2196`
`2197`	`2197`	`if (chown(slaveName.c_str(), buildUser->getUID(), 0))`
`2198`	`2198`	`throw SysError("changing owner of pseudoterminal slave");`
	`2199`	`+ } else {`
	`2200`	`+ if (grantpt(builderOut.readSide.get()))`
	`2201`	`+ throw SysError("granting access to pseudoterminal slave");`
`2199`	`2202`	`}`
`2200`	`2203`
`2201`	`2204`	`#if 0`